Investigate other memory leaks #1484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2024
Closed
ankur22
force-pushed
the
fix/io-readall-recvloop
branch
from
184556f to
c791237
Compare
ankur22
force-pushed
the
investigate/memory-leaks
branch
from
3786c8f to
2a14612
Compare
ankur22
force-pushed
the
fix/io-readall-recvloop
branch
from
c791237 to
a631b38
Compare
ankur22
force-pushed
the
investigate/memory-leaks
branch
from
2a14612 to
1c80112
Compare
We need to ensure that the reference from request to response and back to request is broken by nilling them out. This then allows the GC to correctly collect the objects and free memory.
ankur22
force-pushed
the
investigate/memory-leaks
branch
from
1c80112 to
ec4ebe0
Compare
This is a POC to understand why memory isn't being deallocated normally without having to do this.
ankur22
force-pushed
the
investigate/memory-leaks
branch
from
8a5dee5 to
658063a
Compare
|
Closing this in favour of the actual solution to the problem #1488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is investigating one thing which is
nilling references to break connections so that the GC will collect unused memory/objects.Why?
To prevent and reduce memory usage/leaks.
Checklist
Related PR(s)/Issue(s)